Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift support #20

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

vibhorgupta-gh
Copy link
Contributor

No description provided.

fi

# Delete runbox
sudo rm -rf $RUNBOX
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis fails with 'No permission to rm runbox'. Hence sudo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange. how does it work for every other worker ?

Copy link
Contributor Author

@vibhorgupta-gh vibhorgupta-gh Jul 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@championswimmer Here is the error. Perhaps it has something to do with the permissions granted from where we are pulling our docker image?

screen shot 2018-07-11 at 7 57 39 pm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local tests and travis passing

@@ -0,0 +1,7 @@
FROM swiftdocker/swift:latest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used https://github.com/swiftdocker/docker-swift for the docker image.


expected="Hello World"
actual="$(cat ${RUNBOX}/run.stdout)"
if [ "$expected" == "$actual" ] ;then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is it coming out to be "Hello World" when according to your source code it should be "HelloWorld"

Copy link
Contributor Author

@vibhorgupta-gh vibhorgupta-gh Jul 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@championswimmer fixed this, updated script.swift

@vibhorgupta-gh vibhorgupta-gh mentioned this pull request Aug 11, 2018
@vibhorgupta-gh
Copy link
Contributor Author

@championswimmer any updates here? I guess this does resolve the issue, please have a look :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants