Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Int32.LeadingZeroCount is not called on .NET 8 #22

Open
go3323 opened this issue Sep 19, 2024 · 1 comment · May be fixed by #24
Open

Int32.LeadingZeroCount is not called on .NET 8 #22

go3323 opened this issue Sep 19, 2024 · 1 comment · May be fixed by #24

Comments

@go3323
Copy link

go3323 commented Sep 19, 2024

The NET7_0 directive does not detect .NET 8 and above. This should be NET7_0_OR_GREATER instead.

This should be changed in two places:

nanoid-net/src/Nanoid/Nanoid.cs

Line 254 in 485c009

#if NET7_0

nanoid-net/src/Nanoid/Nanoid.cs

Line 301 in 485c009

#if !NET7_0

@mmdfmateus
Copy link

curious on what's the impact of this

@kakone kakone linked a pull request Dec 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Uses Int32.LeadingZeroCount on .NET 7.0 or greater kakone/nanoid-net
2 participants
@mmdfmateus @go3323