should be able to return tx.Commit() from closure?

[tbg]

sql: Transaction has already been committed or rolled back

        if err := crdb.ExecuteTx(client.DB, func(tx *sql.Tx) error {
            // do stuff

            return tx.Commit() // works when returning `nil`
        }); err != nil {
            t.Fatalf("%+v", err)
        }

[tamird]

Looks like a wontfix?

cockroach-go/crdb/tx.go

Line 74 in 6fd53f6

// opportunity to react to retryable errors, whereas tx.Commit() doesn't.

[andreimatei]

Yeah... What's the suggestion here, Tobi? Even without the fact that you can't react to a retryable error after you attempt a commit, how would ExecuteTx() know if it's supposed to attempt to commit or if the closure did it?