-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and test sign language video in the container page #3194
base: dev-sign
Are you sure you want to change the base?
Conversation
Signed-off-by: Seokho Son <[email protected]>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Wait, please do not proceed with this yet. |
To see where this is in the review pipeline and follow the progress, please look at the definition review board. |
|
Note: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest using something like one of the following, instead of introducing new sections:
Of course the latter is graphically nicer, but would require that this repo be using the latest Docsy (and possibly wait for an accordion shortcode to land -- a PR is ready, it just hasn't been accepted yet). <summary>
is immediately accessible
For example:
Sign language
[video goes here]
Also, given that the video is prominent when shown, using either a summary element or an accordion hides the video until a reader wishes to consult it. That feels like a better overall page design and general UX to me.
WDYT @nate-double-u @seokho-son et al?
I agree. If we're going to roll out a new template with ## Further Reading as a header, I feel like we should specify what it's for. Otherwise, it may become a bit of a junk drawer, which would undermine the effort we're making to highlight the sign language section. Let us consider dropping "Further reading" in favour of @chalin's suggestion of a "Sign language" section (how ever we want to render that). |
Signed-off-by: Catherine Paganini <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still have maintainer rights, so I went ahead and made the H2 updated 😜
LGTM 😄 |
Signed-off-by: Seokho Son <[email protected]>
Signed-off-by: Seokho Son <[email protected]>
Signed-off-by: Seokho Son <[email protected]>
Hello @chalin @nate-double-u, https://deploy-preview-3194--cncfglossary.netlify.app/container/
I would also appreciate the opinions of others like @CathPag @jtjackson. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for showing both alternatives.
I'd be ok either way. What do the WG members have to say about it?
My suggestion would be to create a Hugo shortcode that accepts an YouTube video ID as argument, and then displays whichever solution is adopted here (summary or heading).
I get the impression that there is a preferences for a regular H2 heading at the end of the page. As I mentioned, that works for me. The advantage of using a shortcode is that if we change our mind later, it will be easy to adjust across the board.
WDYT?
Also see inline suggested adjustments.
Co-authored-by: Patrice Chalin <[email protected]> Signed-off-by: Noah Ispas <[email protected]>
Co-authored-by: Patrice Chalin <[email protected]> Signed-off-by: Noah Ispas <[email protected]>
Co-authored-by: Patrice Chalin <[email protected]> Signed-off-by: Noah Ispas <[email protected]>
I prefer the second option. What do we need to proceed here? @seokho-son @nate-double-u @CathPag |
I would like to be notified as well for the next steps. |
Describe your changes
This testing PR is to support #3044
Will see and discuss about the layout from the preview.
Related issue number or link (ex:
resolves #issue-number
)Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.