New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify e2e.logs for cncf/k8s-conformance#1171 #44

Open

hh opened this issue Oct 20, 2020 · 1 comment

Contributor

hh commented Oct 20, 2020

cncf/k8s-conformance#1171

Passed with only one test. It should have failed.

Both the e2e.log and junit.xml only show a single test run/passed.

Contributor Author

hh commented Oct 20, 2020

Maybe update the xml unmarshalling to support Skipped, then test for it when adding to the submittedTestMap:

type TestCase struct {
                XMLName xml.Name `xml:"testcase"`
        Name    string   `xml:"name,attr"`
                Skipped BoolIfElementPresent `xml:"hide"`
}

type BoolIfElementPresent bool

func (c *BoolIfElementPresent) UnmarshalXML(d *xml.Decoder, start xml.StartElement) error {
    var v string
    d.DecodeElement(&v, &start)
    *c = true
    return nil
}

Based on exploring: https://stackoverflow.com/questions/23724591/golang-unmarshal-self-closing-tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment