Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add constants for driver lookup values #200

Open
jdolitsky opened this issue Mar 20, 2020 · 1 comment
Open

Add constants for driver lookup values #200

jdolitsky opened this issue Mar 20, 2020 · 1 comment

Comments

@jdolitsky
Copy link

In the Lookup method in the package github.com/cnabio/cnab-go/driver/lookup is using hardcoded strings such as "docker" to determine the driver. Those strings should ideally be made constants somewhere in this repo for other libraries to use.
@jdolitsky jdolitsky mentioned this issue Mar 20, 2020
Merged
@jdolitsky
Copy link
Author

Source:

cnab-go/driver/lookup/lookup.go

Line 13 in fc67661

func Lookup(name string) (driver.Driver, error) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jdolitsky