Skip to content
This repository has been archived by the owner on Oct 19, 2021. It is now read-only.

Last update broke splats #635

Open
jhessin opened this issue Feb 16, 2018 · 4 comments
Open

Last update broke splats #635

jhessin opened this issue Feb 16, 2018 · 4 comments

Comments

@jhessin
Copy link

jhessin commented Feb 16, 2018

The latest update fixed the issue with computed object keys #633 but it seems to have broken splats

data.push { doc.data()..., id: doc.id }

Now gives me a coffeescript_error

NOTE: I have tested this code using the latest coffeescript and it works fine.

@swang
Copy link
Collaborator

swang commented Feb 16, 2018

coffeescript_error occurs when there is a parsing error in coffeescript itself.

What does coffee -v return for you? it is possible you the version your environment is using does not support splats.

@jhessin
Copy link
Author

jhessin commented Feb 16, 2018

You misunderstood. CoffeeScript isn’t giving me the error - only coffelint is.

@swang
Copy link
Collaborator

swang commented Feb 16, 2018

To clarify, the error and the error from #633 you are seeing was generated because coffeelint was unable to parse the coffeescript it was trying to lint, that is what coffeescript_error means. coffeelint can't lint something that's not parseable by the version of coffeescript it's using.

This bit of code seems to run fine for me with the latest version of coffeelint. So either there is some weird override happening, or the coffeescript in the library is being ignored or something didn't get updated.

Knowing what version of coffee and coffeelint your environment is seeing would help clarify what's going on. Do you also have a package-lock.json file?

@jhessin
Copy link
Author

jhessin commented Feb 16, 2018

This may be an issue with my editor. It seems to have downgraded coffeelint to 2.0.7 without my permission.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants