Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Add support for mixed instances policy #52

Open
michellebeard opened this issue Dec 7, 2023 · 1 comment
Open

Feature request: Add support for mixed instances policy #52

michellebeard opened this issue Dec 7, 2023 · 1 comment
Labels
feature-request Request for a new feature

Comments

@michellebeard
Copy link

michellebeard commented Dec 7, 2023 •
edited
Loading

Use case

Add support to analyze EKS clusters that use a MixedInstancePolicy.

eksup analyze --cluster foo --region us-west-2 
Error: Launch template not found, launch configuration is not supported

Note: The error message provided about is misleading or limiting. The cluster being scanned does not use launch configurations.

Solution/User Experience

Enable eksup to autodetect a mixed instance policy.

Alternative solutions

Add support to disable ASG checks.
@michellebeard michellebeard added feature-request Request for a new feature triage labels Dec 7, 2023
@bryantbiggs bryantbiggs removed the triage label Dec 7, 2023
@bryantbiggs
Copy link
Member

hmmm, yes we could probably just log out something like "Not found - skipping check xxx" to let it keep analyzing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request Request for a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bryantbiggs @michellebeard