feat(aws_instance): treat missing data on cloudwatchmetric #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @johncblandii, @joe-niland |
joe-niland
reviewed
Feb 9, 2024
There was a problem hiding this comment.
@haidargit looks good. I think it would help to add input validation for this variable.
joe-niland
reviewed
Feb 9, 2024
haidargit
force-pushed
the
feature/cloudwatch-treat-missing-data
branch
from
7ec3fe6 to
45ec3c3
Compare
Co-authored-by: Joe Niland <[email protected]>
|
Validation added, @joe-niland, Thanks for the correction! |
…idargit/terraform-aws-ec2-instance into feature/cloudwatch-treat-missing-data
|
/terratest |
|
variable added on Thanks |
|
/terratest |
joe-niland
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
The PR enables the treat_missing_data argument for the cloudwatch metric alarm resource on this ec2 module.
terraform-aws-ec2-instance/cloudwatch-alarm.tf
Line 11 in bf54345
why
Users may have specific run schedules, triggering alerts in CloudWatch, e.g., for missing data during offline periods (instance stopped state, hibernate, restart, etc.).
This
treat_missing_datavariable will enable the CloudWatch alarms to set custom responses, which are "missing", "ignore", "breaching" and "notBreaching", for the data gaps that occur and keep the EC2 alarms condition in a desired state.references
Kindly review this PR for any possible improvements. Thank you