Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail on invalid config #19

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions .github/workflows/test-empty-setting.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
name: Test non-existent setting
on:
# # Uncomment when test added first time to register workflow and comment it back after workflow would be registered
# #
# # Added pull_request to register workflow from the PR.
# # Read more https://stackoverflow.com/questions/63362126/github-actions-how-to-run-a-workflow-created-on-a-non-master-branch-from-the-wo
# pull_request: {}
workflow_dispatch: {}

jobs:
test:
runs-on: ubuntu-latest
continue-on-error: true
outputs:
result: ${{ steps.current.outputs.value }}
outcome: ${{ steps.current.outcome }}
steps:
- name: Setup terraform
uses: hashicorp/setup-terraform@v2
- name: Setup atmos
uses: cloudposse/[email protected]
with:
install-wrapper: false
- name: Checkout
uses: actions/checkout@v3

- uses: ./
id: current
with:
component: foo
stack: core-ue1-dev
settings-path: settings.level5

assert:
runs-on: ubuntu-latest
if: always()
needs: [test]
steps:
- uses: nick-fields/assert-action@v1
with:
expected: success
actual: ${{ needs.test.outputs.outcome }}

- uses: nick-fields/assert-action@v1
with:
expected: ""
actual: ${{ needs.test.outputs.result }}

48 changes: 48 additions & 0 deletions .github/workflows/test-negative.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
name: Test non-existent component stack
on:
# # Uncomment when test added first time to register workflow and comment it back after workflow would be registered
# #
# # Added pull_request to register workflow from the PR.
# # Read more https://stackoverflow.com/questions/63362126/github-actions-how-to-run-a-workflow-created-on-a-non-master-branch-from-the-wo
# pull_request: {}
workflow_dispatch: {}

jobs:
test:
runs-on: ubuntu-latest
continue-on-error: true
outputs:
result: ${{ steps.current.outputs.value }}
outcome: ${{ steps.current.outcome }}
steps:
- name: Setup terraform
uses: hashicorp/setup-terraform@v2
- name: Setup atmos
uses: cloudposse/[email protected]
with:
install-wrapper: false
- name: Checkout
uses: actions/checkout@v3

- uses: ./
id: current
with:
component: bar
stack: core-ue1-dev
settings-path: settings.level1.level2.level3.secrets-arn

assert:
runs-on: ubuntu-latest
if: always()
needs: [test]
steps:
- uses: nick-fields/assert-action@v1
with:
expected: failure
actual: ${{ needs.test.outputs.outcome }}

- uses: nick-fields/assert-action@v1
with:
expected: ""
actual: ${{ needs.test.outputs.result }}

48 changes: 48 additions & 0 deletions .github/workflows/test-wrong-atmos-config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
name: Test wrong atmos config
on:
# # Uncomment when test added first time to register workflow and comment it back after workflow would be registered
# #
# # Added pull_request to register workflow from the PR.
# # Read more https://stackoverflow.com/questions/63362126/github-actions-how-to-run-a-workflow-created-on-a-non-master-branch-from-the-wo
# pull_request: {}
workflow_dispatch: {}

env:
ATMOS_CLI_CONFIG_PATH: /tmp
ATMOS_BASE_PATH: /tmp

jobs:
test:
runs-on: ubuntu-latest
continue-on-error: true
outputs:
result: ${{ steps.current.outputs.value }}
outcome: ${{ steps.current.outcome }}
steps:
- name: Setup terraform
uses: hashicorp/setup-terraform@v2
- name: Setup atmos
uses: cloudposse/[email protected]
with:
install-wrapper: false

- name: Checkout
uses: actions/checkout@v3

- uses: ./
id: current
with:
component: foo
stack: core-ue1-dev
settings-path: settings.level1.level2.level3.secrets-arn

assert:
runs-on: ubuntu-latest
if: always()
needs: [test]
steps:
- uses: nick-fields/assert-action@v1
with:
expected: failure
actual: ${{ needs.test.outputs.outcome }}

4 changes: 2 additions & 2 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,6 @@ runs:
${{ inputs.component }} \
-s ${{ inputs.stack }} \
--format json \
--file "$OUTPUT_FILE" || echo '{}' > "$OUTPUT_FILE"
value=$(jq -rc --arg key ${{ inputs.settings-path }} '. | getpath($key | split("."))' "$OUTPUT_FILE")
--file "$OUTPUT_FILE"
value=$(jq -rc --arg key ${{ inputs.settings-path }} '. | getpath($key | split(".")) | if . == null then "" else . end' "$OUTPUT_FILE")
echo "value=$value" >> $GITHUB_OUTPUT
Loading