-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial draft of helmfile-linter #93
Open
dylanbannon
wants to merge
21
commits into
master
Choose a base branch
from
helmfile-lint
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the Docker container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
helmfile-linter
action, which will print output fromhelmfile lint
in the github actions console for every helmfile identified in a repo.Tested using the cloudposse/helmfile-linter-test repo. Example of successful test and expected outputs: https://github.com/cloudposse/helmfile-linter-test/runs/1730194441?check_suite_focus=true.
NB: The cloudposse/helmfile-linter-test repo should be deleted once this PR is merged.
Design decisions:
helmfile lint
:It must be named helmfile.d/*.{yaml,yml}, helmfile.yaml, or charts.yaml, or otherwise specified with the --file flag
, except that no effort is made to identify helmfiles with custom names (the ones that would need to be specified with the--file
flag)..github
directory can contain a large number ofyaml
files, some of which could conceivably be namedhelmfile.yaml
orcharts.yaml
, none of which are likely to be functional hemlfiles,helmfile-linter
ignores any files in that directory.