-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define keyNames to backups.secrets #384
base: main
Are you sure you want to change the base?
Conversation
@ercpereda We require that you signoff on your commits? Can you please take a look at this: https://github.com/cloudnative-pg/charts/pull/384/checks?check_run_id=29909669764 |
Signed-off-by: Ernesto R. C. Pereda <[email protected]>
@itay-grudev Thank you for the response. The commit is now signoff. |
@itay-grudev Something else that can be done to get this merge? Thank you? |
A local negative gravitational anomaly. Something that accelerates time, but just in my frame of reference. |
This would be great to have, ran into this limitation when using an ObjectBucketClaim with storage class |
@ercpereda Would you please be able to add a test for this in: https://github.com/cloudnative-pg/charts/tree/main/charts/cluster/test/postgresql-cluster-configuration This tests whether non-default configuration properties get forwarded correctly and ensures we don't accidentally break something in the future. |
@ercpereda It also seems like there is a test failure:
|
Hi, this is my first contribution so please let me know if I have missed anything.
This PR adds the posibility to define the name of the keys for the secret containing the credentials of the backups.
Fixes #383