Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define keyNames to backups.secrets #384

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ercpereda
Copy link

Hi, this is my first contribution so please let me know if I have missed anything.

This PR adds the posibility to define the name of the keys for the secret containing the credentials of the backups.

Fixes #383

@itay-grudev
Copy link
Collaborator

@ercpereda We require that you signoff on your commits? Can you please take a look at this: https://github.com/cloudnative-pg/charts/pull/384/checks?check_run_id=29909669764

@ercpereda
Copy link
Author

@itay-grudev Thank you for the response. The commit is now signoff.

@itay-grudev itay-grudev added the chart( cluster ) Related to the cluster chart label Oct 4, 2024
@ercpereda
Copy link
Author

@itay-grudev Something else that can be done to get this merge? Thank you?

@itay-grudev
Copy link
Collaborator

A local negative gravitational anomaly. Something that accelerates time, but just in my frame of reference.

@jorgebsa
Copy link

This would be great to have, ran into this limitation when using an ObjectBucketClaim with storage class openshift-storage.noobaa.io, which prefixes the keys with AWS_ on the generated secret. Had to resort to FluxCD's HelmRelease's valuesFrom to pass the values to the chart

@itay-grudev
Copy link
Collaborator

@ercpereda Would you please be able to add a test for this in: https://github.com/cloudnative-pg/charts/tree/main/charts/cluster/test/postgresql-cluster-configuration

This tests whether non-default configuration properties get forwarded correctly and ensures we don't accidentally break something in the future.

@itay-grudev
Copy link
Collaborator

@ercpereda It also seems like there is a test failure:

Error: template: cluster/templates/cluster.yaml:103:5: executing "cluster/templates/cluster.yaml" at <include "cluster.bootstrap" .>: error calling include: template: cluster/templates/_bootstrap.tpl:90:10: executing "cluster.bootstrap" at <include "cluster.barmanObjectStoreConfig" $d>: error calling include: template: cluster/templates/_barman_object_store.tpl:28:104: executing "cluster.barmanObjectStoreConfig" at <.scope.secret.keyNames.accessKey>: nil pointer evaluating interface {}.accessKey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart( cluster ) Related to the cluster chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[backups] Allow specify the secret keys if an existing secret is created.
3 participants