Does the binding controller need to watch the cfapp resource

[georgethebeatle]

Background

While introducing support for service bindings to managed service instances we spotted two things

• The binding controller is currently watching the cfapp resource

• In the reconcile method of the binding controller we are getting the cfapp and do not do anything with the object (other than returning an error if the get operation fails)

Action to take

• Find out if this behaviour is really needed and remove it if not.
• If the app lookup is needed just to validate that the app is there we could just get it without assigning it to a local var to make it clear that the get is intentional and that we do not need to look at the result

r.k8sClient.Get(ctx, types.NamespacedName{Name: cfServiceBinding.Spec.AppRef.Name, Namespace: cfServiceBinding.Namespace}, new(korifiv1alpha1.CFApp))

Dev notes

• One reason to watch apps from the binding controller might be to allow us to make a binding unready once its app goes away
• Even if the avove is true do we still need to lookup the app? Wouldn't the servicebinding.io binding beome unready if the statefulset goes away? In this case the cfServiceBinding will also go into a bad state