Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop assigning VIPs to internal routes #3712

Open
tcdowney opened this issue Apr 1, 2024 · 0 comments
Open

Stop assigning VIPs to internal routes #3712

tcdowney opened this issue Apr 1, 2024 · 0 comments
Labels
networking issues that reference network-oriented features like ASGs or container networks

Comments

@tcdowney
Copy link
Member

tcdowney commented Apr 1, 2024

This is a tech-debt issue and low priority. I'm mostly logging it so that we can capture the fact that this is dead code.

Issue

Cloud Controller is assigning virtual IP addresses to internal routes. This was added to support internal "service mesh" domains using Istio, but the experimental Istio support has long since been deprecated:

This code occasionally causes bugs, so removing it could reduce the long term maintenance costs of Cloud Controller.

Context

These VIPs were sent along as part of the route definition to Istio Copilot.

The current container-to-container (c2c) networking system does not make use of these VIPs and they're otherwise ignored by the platform.

Steps to Reproduce

Nothing to reproduce, just dead code. The A/C for this would be to remove the VIP-related code from CCNG and capi-release, deploy, and then confirm that internal c2c routing continues to work.

Possible Fix

Remove VIP related code from the Route model in Cloud Controller and then remove vip_range related properties and templating from capi-release.

https://github.com/search?q=repo%3Acloudfoundry%2Fcapi-release+vip_range&type=code

@tcdowney tcdowney added the networking issues that reference network-oriented features like ASGs or container networks label Apr 1, 2024
@moleske moleske mentioned this issue Apr 21, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
networking issues that reference network-oriented features like ASGs or container networks
Projects
None yet
Development

No branches or pull requests

1 participant