Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse and nav to initial comment or whitespace #1286

Merged
merged 1 commit into from
Oct 1, 2022
Merged

Conversation

mainej
Copy link
Collaborator

@mainej mainej commented Sep 30, 2022

Addresses #1252.

Note that this standardizes which node we parse to (always the :forms node) but doesn't eliminate any defensive checks for nil zlocs. We still have to be careful about nils because an empty file doesn't contain any nodes besides the root :forms node, which means any zipper navigation will return nil.

If and when clj-commons/rewrite-clj#189 is fixed, we can switch to the rewrite-clj implementation.

  • I created an issue to discuss the problem I am trying to solve or an open issue already exists.
  • I added a new entry to CHANGELOG.md
  • I updated documentation if applicable (docs folder)

@mainej mainej requested a review from ericdallo September 30, 2022 16:32
@ericdallo ericdallo merged commit 8041c06 into master Oct 1, 2022
@ericdallo ericdallo deleted the of-root-string branch October 1, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants