Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome 60 will require blobs to be CORS whitelisted #1

Open
yoshuawuyts opened this issue Jul 4, 2017 · 2 comments
Open

Chrome 60 will require blobs to be CORS whitelisted #1

yoshuawuyts opened this issue Jul 4, 2017 · 2 comments

Comments

@yoshuawuyts
Copy link
Member

yoshuawuyts commented Jul 4, 2017

Not sure what implications are, but we should at least inform people of this.

Also cc/ @lrlna, do we have thoughts on CORS in merry? Do you know how CORS is handled in nginx / CDNs?

@lrlna
Copy link
Member

lrlna commented Jul 19, 2017

hey lol sorry i am horrible at emails coming in from github

SO! I don't know how to handle it on the nginx level, never done it there. But with merry, you really just set the appropriate headers and methods on the res obj, kind of like i did here. <-- this was done for a previous version of merry that expected a middleware thing, but i can tweek it for this version of merry.

@yoshuawuyts
Copy link
Member Author

Yeah, good one - we should probs also create one for https://www.npmjs.com/package/helmet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants