NODE_ENV doesn't work on windows

[yoshuawuyts]

See choojs/create-choo-app#20

λ npm start

> [email protected] start D:\gitwork\choo-electon-app-01
> NODE_ENV=development electron main.js

'NODE_ENV' is not recognized as an internal or external command,
operable program or batch file.

[conoro]

This works on Windows:

"start": "set NODE_ENV=development && electron main.js"

[chrisdwheatley]

Took a quick look at this & the related issue in create-choo-app, I think you might be able to get away with not using cross-env (for now at least) by removing the setting of NODE_ENV and allowing users to set it themselves when desired.

e.g. UNIX users run NODE_ENV=production && npm start, Windows users run set NODE_ENV=production & npm start and so on and so forth for other platforms.

There may be some intricacies I'm missing so feel free to correct me if that's the case.

[yoshuawuyts]

@chrisdwheatley from my own experience I tend to forget setting NODE_ENV=production all too often, haha — something we might do is set the knob to production in bankai build by default, so we can evade this.

A PR would be very welcome to set that behavior by default in Bankai, and then another to remove cross-env from all our create-choo-* repos! — hope this make sense; thanks! ✨