Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

components #9

Open
3 tasks
yoshuawuyts opened this issue Jul 23, 2017 · 3 comments
Open
3 tasks

components #9

yoshuawuyts opened this issue Jul 23, 2017 · 3 comments

Comments

@yoshuawuyts
Copy link
Member

Was thinking including nanocomponent might make sense. Perhaps a lil "hi there" screen with a main route and 404 route set up, including a lil header or smth. Then also include assert-snapshot with tape so folks can figure out how to do UI testing right.

Depends on new nanocomponent.

cc/ @bcomnes

todo

  • create header component (components/header.js)
  • setup testing (test/index.js, test/header.js)
  • create a test-save script (or similar) to save the new snapshot
@bcomnes
Copy link

bcomnes commented Jul 23, 2017

+1 to adding nanocomponent by default.

@bcomnes
Copy link

bcomnes commented Jul 23, 2017

Also setting up UI testing would be ace. I still need to sort out how to do that.

@niallobrien
Copy link

The default view generated mentions that a component folder is included, however, it's not. Are there still plans to add this? Thanks.

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants