Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't set lbvserver resource to have persistence timeout of 0 #44

Open
BraddMPiontek opened this issue Oct 27, 2020 · 2 comments
Open
Assignees

Comments

@BraddMPiontek
Copy link

We are using this API indirectly via the terrafrom citrixadc provider and are having the issue described
in this issue.

The issue I'm seeing is we can't set the lb_persistenttimeout (Timeout) on the netscaler because when I do this, the value of zero is omitted from the JSON payload, even though this is a valid value (and is the preferred value for this setting per citrix docs)

@chiradeep
Copy link
Owner

this line?

Timeout int `json:"timeout,omitempty"`

@BraddMPiontek
Copy link
Author

BraddMPiontek commented Oct 27, 2020

No, the specific one I care about is:

https://github.com/chiradeep/go-nitro/blob/master/config/lb/lbvserver.go#L125

However, this would apply to any netscaler integers where 0 is a valid value.

I forked your code and removed the omitempty (as a simple test, this likely is not the right solution) and built it into the terraform-provider-vshere provider, and tested with that and I'm now able to set that specific value to 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants