Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for using custom SSH keys, including encrypted keys #74

Closed
bortels opened this issue Jan 25, 2022 · 3 comments
Closed

Allow for using custom SSH keys, including encrypted keys #74

bortels opened this issue Jan 25, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@bortels
Copy link

bortels commented Jan 25, 2022

I get why - but it might be nice to at least have an option to choose and use a pre-existing encrypted ssh key, or to encrypt the key and save the password for it in the keychain (I'm on macOS).

@toby
Copy link
Contributor

toby commented Jan 27, 2022

I agree! You should be able to specify the key you'd like to use for your account.

@toby toby added the enhancement New feature or request label Jan 27, 2022
@toby toby changed the title You're creating and using an unencrypted private key Allow for using custom SSH keys, including encrypted keys Jan 27, 2022
@toby
Copy link
Contributor

toby commented Mar 29, 2022

You can now use a custom key with the CHARM_IDENTITY_KEY env var:

https://github.com/charmbracelet/charm/blob/main/client/client.go#L36

We should probably also provide a global -i flag and we also still need to support encrypted keys. I'll open up two new issues for that though.

@toby toby closed this as completed Mar 29, 2022
@toby
Copy link
Contributor

toby commented Mar 29, 2022

Added #107 and #106.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants