fix(help): use length of groups, not items within a group, for separator behavior #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blvrd
commented
Jul 26, 2024
| if i < len(group)-1 { | ||
| if i < len(groups)-1 { |
There was a problem hiding this comment.
In the case of columns containing two items, this essentially said if i < 1, add the separator. This led to only the 0th column receiving the separator, no matter how many other columns are displayed.
|
I already had opened a PR for this: #554 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #568
In the demos below, I'm using
xxxxxxas theFullSeparatorto clearly demonstrate the behavior before/after.Behavior before this fix
Behavior after this fix: