Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report full stack traces when detecting leaked clients. #376

Merged
merged 3 commits into from
Dec 15, 2022

Conversation

zenhack
Copy link
Contributor

@zenhack zenhack commented Dec 10, 2022

This patch adjusts the logic for detecting client leaks to include full stack traces for where they were created, rather than just the source location.

This patch adjusts the logic for detecting client leaks to include full
stack traces for where they were created, rather than just the source
location.
@zenhack
Copy link
Contributor Author

zenhack commented Dec 10, 2022

Well this is a new one:

https://github.com/capnproto/go-capnproto2/actions/runs/3662127729/jobs/6190989469#step:5:1531

I have a hard time believing this patch introduced that.

@zenhack
Copy link
Contributor Author

zenhack commented Dec 13, 2022

Opened #377 for the failure, re-running.

@lthibault
Copy link
Collaborator

lthibault commented Dec 13, 2022

Now seeing:

--- FAIL: TestSendDisembargo (0.01s)
    --- FAIL: TestSendDisembargo/SendQueuedResultToCaller (0.01s)
Error:         level1_test.go:285: Received finish message; want disembargo
Error:         level0_test.go:2085: conn error: rpc: send release: send message: context canceled
FAIL
exit status 1

@zenhack zenhack merged commit d139c10 into capnproto:main Dec 15, 2022
@zenhack zenhack deleted the leak-stacks branch December 15, 2022 17:04
@zenhack zenhack mentioned this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants