Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-idiomatic getters #353

Open
danieleades opened this issue Nov 22, 2022 · 1 comment
Open

non-idiomatic getters #353

danieleades opened this issue Nov 22, 2022 · 1 comment

Comments

@danieleades
Copy link
Contributor

the 'getters' in this library (both internal and generated) are non-idiomatic. In Rust, it is considered non-idiomatic to prefix getters with get_.

see RFC #344

obviously fixing this would be a BREAKING CHANGE
@danieleades
Copy link
Contributor Author

the ROI on this change is not likely to be amazing. Just on a one-man quest here to reduce the local entropy in the universe...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danieleades