Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding viewBounds function to return map view bounds of all corners i… #171

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Adding viewBounds function to return map view bounds of all corners i… #171

wants to merge 5 commits into from

Conversation

jjozwiak
Copy link

@jjozwiak jjozwiak commented May 7, 2022

…n Lat/Lng. Based on contribution by @J-Gonzalez PR #81 but updated to match project structure now being used in main branch

@jjozwiak jjozwiak mentioned this pull request May 7, 2022
Open
@selected-pixel-jameson
Copy link

selected-pixel-jameson commented May 12, 2022 •
edited
Loading

@tafelnl If we get the conflicts resolved on this can we get this merged?

tafelnl
tafelnl requested changes May 13, 2022
View reviewed changes
Copy link
Member

@tafelnl tafelnl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. Just reviewed it. Can you take a look and also resolve the merge conflicts?

src/web.ts Outdated Show resolved Hide resolved
src/definitions.ts Outdated Show resolved Hide resolved
@jjozwiak
Adding viewBounds function to return map view bounds of all corners i…
7aa39d8 
…n Lat/Lng. Based on contribution by @J-Gonzalez PR capacitor-community#81 but updated to match project structure now being used in main branch
@jjozwiak jjozwiak force-pushed the jjozwiak/view-bounds branch from bfefc37 to 7aa39d8 Compare May 13, 2022 14:26
@jjozwiak
Updates to viewBounds implementation
8595a58 
Changing viewBounds to getViewBounds and adding ViewBoundsResult interface to provide a return type for the getViewBounds method
@jjozwiak
Copy link
Author

Hi @tafelnl , thanks for the review and feedback. I rebased this branch, resolved merge conflicts, and implemented your feedback. Please let me know if there's anything else. Cheers

jjozwiak added 2 commits May 24, 2022 23:26
@jjozwiak
Updates to viewBounds implementation
03f74c0 
Changing viewBounds to getViewBounds and adding ViewBoundsResult interface to provide a return type for the getViewBounds method
@jjozwiak
Merge branch 'jjozwiak/view-bounds' of github.com:jjozwiak/google-map…
59b6bfa 
…s into jjozwiak/view-bounds
@jjozwiak
Copy link
Author

Hi @tafelnl,
I pushed the requested updates and signed the commits for this PR. Is there anything else needed to merge this into main?
Thank you

@selected-pixel-jameson
Copy link

Hi @tafelnl. Is there anyway we can get this merged? Trying to take a project to production and would like to use this repo instead of our fork if at all possible. Thank you!

1 similar comment
@selected-pixel-jameson
Copy link

Hi @tafelnl. Is there anyway we can get this merged? Trying to take a project to production and would like to use this repo instead of our fork if at all possible. Thank you!

@selected-pixel-jameson
Copy link

@tafelnl Is there something we can do to get this merged? Are we missing something?

@igor-xx
Copy link

igor-xx commented Jul 15, 2024

@tafelnl @hemangsk could anoyone please merge this? or is there anything else preventig you from doing it?

@Jador-de-Vries
Copy link

Bumping as I'd also like to see this implemented!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tafelnl tafelnl tafelnl requested changes

@keyurboss keyurboss keyurboss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jjozwiak @selected-pixel-jameson @igor-xx @Jador-de-Vries @tafelnl @keyurboss