-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow map view to scroll along with rest of the page #7
Comments
Congratulation for your great plugin! Do you already know, when you want to implement this? Because for me it is essential when I want to use this plugin in production. |
Hey @tototares, I've a solution for this in mind using https://stackoverflow.com/a/36468377/5056792 and was hoping to try it over the weekend. Would you be interested in testing out the PR when it's ready? |
Great! Yeah sure, let me know when the PR is ready 👍 |
Hey @tototares , unfortunately it didn't work out as expected. Here's a PR which has the stuff I tried while implementing it #13. This grabs the new coordinates of the div when it is scrolled and sends to the plugin, plugin is then supposed to scroll its native scroll view, and that part is not working (not sure what's the reason). |
Hey @hemangsk , |
@hemangsk Is there anyway we can revisit this? This along with the info boxes are the two items on my list that would prevent me from using this in a production environment. |
@selected-pixel-jameson there's no way you can have the map scroll with the content - the way it works is that there's a map behind the viewport and there's a cutout of your current viewport to show the map. See here for a visual explanation. (I mean, there's always a way, but it will have to be a massively hackey-way -- my recommendation would be to use the Javascript map if you need scrolling, and use the native map for specific native viewing) |
@gbrits Thank you! This definitely sheds some light on this. I think that we will probably just take your approach and instead use the JS implementation but change the UX around it so that it's not being interacted with and more or less a static image. |
but keeping this pinned bc if someone can work out a reasonably hacky solution, it'll be really cool. heavy demand for this feature :D |
I have managed to have something decent. Continuing with @hemangsk 's initial idea but on Android. It have some problems with performance but... it works. Screenrecorder-2021-06-16-16-19-16-750.mp4You can see the red background behind the map when moving. Much more lag is appreciated because I am recording screen. But still, it is the only problem that I see and it can be improved for sure. |
This is some epic stuff @seravifer 🤯 Great job! |
Do we have an approach defined for this based on the two different suggestions? Right now it seems like the two discussion points are: Performance Overlaying HTML Elements |
No description provided.
The text was updated successfully, but these errors were encountered: