-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shapes): add support for drawing polyline, polygon and circle #157
Comments
@galilov will soon start with the implementation on Android. If someone would like to contribute and help with the iOS part, please feel free to chime in :) |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
Partly shipped in |
Hi, Is there a timeline for adding Polylines to this Plugin? It works wonderfully in my app BTW. |
=
did you mean polyline works on your app ?how can i add polyline to map? |
Hi Good Morning, What I meant is that the basic map, zoom, maptype etc all work. My question is your second question:
I see it's not officially part of the plugin but I've seen bits referring to polylines in the code. |
@WynOwen72 @asma-omar i was able to use polyline feature on the map result |
if the team hasn't gotten this feature already developed, i can take my time to contribute to this |
My skills are weak in Java and Swift but i'd love to take a peek. |
PRs are welcome! Please try to adhere to the coding guidelines and principles in the codebase. That'll make it easier for me to review it. |
alright |
This comment was marked as duplicate.
This comment was marked as duplicate.
@jidlxs and @WynOwen72 i plan to work on this and push it tomorrow |
Thank you :-) |
This is amazing. |
hello @jldlxs @WynOwen72 @tafelnl @tafelnl please review this and let me know if ok or there is still some works |
It should be possible to draw basic shapes on the map. There's actually already an open PR that adds this: #149
It adds the methods
addPolygon
,addPolyline
andaddCircle
with some options. E.g. to fill them with a solid color and to adjust the color of the stroke (i.e. the border of the shape).However, to be on par with the API the Google SDK offers, some additional functionality is needed as well.
We will first focus on completing the functionality of the
polygon
shape only. Later on, we will add similar functionality to thepolyline
andcircle
shapes as well. This way we keep the scope smaller. The requirements are as follows:The API in the PR regarding the
polygon
(as said above) only has theaddPolygon
method right now. But it should be on par with the API that the Android SDK of Google itself offers (can be found here).More specifically, this will thus entail the following changes:
addMarker
method has similar functionality.PolygonOptions
of the PR already supports specifying thepoints
,tag
,strokeColor
,fillColor
,strokeWidth
,zIndex
and thevisibility
. Support should also be added forclickable
,geodesic
,holes
,strokePattern
,strokeJointType
.getPolygon(id: string)
method, that returns all properties of the specified polygon. For reference: thegetḾap
method has similar functionality.updatePolygon(id: string, preferences: object)
method, which accepts the same preference parameters as theaddMarker
method, so the polygon can be updated.removePolygon(id: string)
method, so a polygon can be removed (remember to update the list mentioned in 1 as well).Bonus 1: it should be possible to - instead of a solid color fill - apply a pattern of images to a polygon. For more information, check this Stack Overflow question
Bonus 2: it should be possible to place the shapes on top of the markers. Normally they are drawn behind the markers.
The text was updated successfully, but these errors were encountered: