-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add thumbnailImage projection #115
Comments
After looking at the Android code, and at the relevant docs (https://developer.android.com/reference/android/provider/ContactsContract.Contacts.Photo#PHOTO), it seems that the current behaviour is to get the thumbnail size asset on Android, and the full size asset on iOS. Ideally, we would need to parametrise the
|
Yeah, I have done some work on this. I've got a few changes on device locally. I'll commit them when I've got the time. If I remember correctly, I was struggling with keeping it both consistent and backwards compatible. |
Got a work in progress branch here: https://github.com/capacitor-community/contacts/tree/feat%2Fadd-thumbnail-projection |
@tafelnl could you please create a pull request to add this feature finally? 😊 |
Is your feature request related to a problem? Please describe.
As it stands, on iOS the plugin retrieves the full size image, which can slow things down considerably.
Describe the solution you'd like
When displaying contact images as thumbnails, it would be much more efficient to retrieve
CNContactThumbnailImageDataKey
instead ofCNContactImageDataKey
.I'm happy to give it a shot on iOS. I'd simply add a new projection for
thumbnailImage
and implement the Swift plugin accordingly. I have no experience with Android dev unfortunately.Describe alternatives you've considered
We could:
The text was updated successfully, but these errors were encountered: