"Non-ID" keys #117
Open
"Non-ID" keys #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
nils
commented
Sep 18, 2024
|
|
||
| for (let idx = 0; idx < paths.length; idx++) { | ||
| const entity = getEntityByContextPath(paths.slice(0, idx + 1), txContext.hasComp) | ||
| const entityID = entityIDs[idx] | ||
| const entityPathVal = `${entity.name}(${entityID})` | ||
| const entityPathVal = {target: entity.name, key: entityID}; |
There was a problem hiding this comment.
This illustrates one main change: paths are expressed as JSON arrays like
[{target: "RootEntity", key: {ID: "..."}}, {target: "Level1Entity", key: {ID: "..."}}]instead of
"RootEntity(...)/Level1Entity(...)"
…cking into feat/non-ID-keys
nils
commented
Sep 19, 2024
| serviceEntity: target.name || target, | ||
| changes: changes.filter(c => c.valueChangedFrom || c.valueChangedTo).map((c) => ({ | ||
| ...c, | ||
| serviceEntityPath: stringifyPath(c.serviceEntityPath), |
There was a problem hiding this comment.
As discussed, if there is a single-key situation, we now serialize paths to the 'old' format before saving to the db.
|
@Sv7enNowitzki can you please have a look at the tests and give an OK to merge this into the main branch? |
Hi @nkaputnik No, as I mentioned earlier in the email, the current code does not work in a CAP application, such as simple-bookshop. Best Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our project, we are dealing with a legacy data model that does not follow the best practices regarding primary keys, and there is nothing we can change about it in the mid term.
This PR aims at introducing the capability to deal with change logs for entities with complex/composite keys.
It does not cover all scenarios, but at least some situations.