Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG support #4

Open
nottrobin opened this issue Feb 27, 2019 · 5 comments
Open

SVG support #4

nottrobin opened this issue Feb 27, 2019 · 5 comments

Comments

@nottrobin
Copy link
Contributor

Mostly, fl_sanitise

@jpmartinspt
Copy link

Is this still a thing? @nottrobin @albertkol

@nottrobin
Copy link
Contributor Author

nottrobin commented Oct 14, 2020

Ah. That is a little light on detail. I barely remember this. I'd have to spend a second or two looking into how imagetemplate module interacts with SVGs. @Lukewh may know more but unfortunately we can no longer compel him to respond ☺️. Or maybe @barrymcgee ?

@sowasred2012
Copy link
Contributor

@nottrobin - any luck remembering details on this? We are now both @Lukewh-less and @barrymcgee-less. Could we close?

@aaryanporwal
Copy link

aaryanporwal commented Oct 7, 2024

Just faced this issue. To reproduce, just pass in the image url of an svg.

Here's my code:

{{ image(url="https://assets.ubuntu.com/v1/9e91caf9-Canonical%20Ubuntu%20Summit%20Logo%202024%20with%20text.svg",
                  alt="Ubuntu Summit 2024 Logo",
                  width="350",
                  height="150",
                  hi_def=True,
                  loading="lazy") | safe }}

See that the image url is valid and opens, but somehow image filter doesn't render the image on the website.

Update: This only happens with some svgs. Like this Canonical Logo svg renders just fine:

            {{ image(url="https://assets.ubuntu.com/v1/d86e845a-Canonical_logo_2023.svg",
                    alt="Canonical",
                    width="104",
                    hi_def=True,
                    loading="lazy") | safe
            }}

@albertkol
Copy link
Contributor

Just fix it, m8! This issue is older than COVID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants