Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for python >= 3.12 #288

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

SafaSafari
Copy link

Description of Changes

Fixes #283.

Major Changes Implemented:

  • fix module function
  • fix path class

Pre-Merge Tasks

  • Formatted all modified files w/ python-black
  • Sorted imports for modified files w/ isort
  • Ran flake8 on repo, and fixed any new problems w/ modified files
  • Ran pytest test cases
  • Added brief summary of updates to CHANGELOG (under [Unreleased])

@SafaSafari SafaSafari changed the title fix for python >= 12 fix for python >= 3.12 Aug 9, 2024
@scmanjarrez
Copy link

scmanjarrez commented Oct 6, 2024

Hey, I found your changes, do you mind updating the "import pkg_resources" too? This way we have all the patches in the same repository. The function files() apparently is the replacement. I think we will need to use this zodburi version too https://github.com/Pylons/zodburi/tree/modernize-python-versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'FileFinder' object has no attribute 'find_module'
2 participants