Corrected issues with the boolean operators in the config file being …

[stampedeboss]

the added settings were not seen as valid, for instance, allow-dirty in the configuration file was treated as if it didn't exist since it was a still a string and not a Boolean. I added the additional settings.

…treated as strings.

[florisla]

Hi, what was the result of allow-dirty being treated as if it didn't exist?
What's the desired behavior?

We should add a unit test which covers that behavior.

We also need to

• Fix failing continuous integration checks.
• Move the list of 'bool value name' options to a constant
• Drop the 'Bump version' commits in this branch

[stampedeboss]

It behaved like the parameter wasn’t present in the configuration file and errored out.

…

Sent from my iPhone

On Jan 6, 2021, at 7:57 AM, Floris Lambrechts ***@***.***> wrote:  Hi, what was the result of allow-dirty being treated as if it didn't exist? What's the desired behavior? We should add a unit test which covers that behavior. We also need to Fix failing continuous integration checks. Move the list of 'bool value name' options to a constant Drop the 'Bump version' commits in this branch — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[florisla]

What's going on here? The last commit reverses the first commit...

[florisla]

Hi, I've looked at this a bit.

What already works today in the config file is setting

allow_dirty = True

What does not work (but shouldn't, because it's not uniform with other options such as tag = True):

allow_dirty

And what also fails to work:

allow_dirty = False

Your change does fix that last case.

I'm going to incorporate that and package it up with some unit tests.

[florisla]

@stampedeboss, please see #183 which incorporates your fix.

If you desire the 'automatic commit dirty files' as a feature (from 579f21c), please open a separate issue for that -- as that would require some discussion.