-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow not updating the config file, even when it exists. #169
base: master
Are you sure you want to change the base?
Conversation
Any chance of this getting looked at? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also be updated in the README.
@@ -127,7 +127,7 @@ def main(original_args=None): | |||
|
|||
# store the new version | |||
_update_config_file( | |||
config, config_file, config_newlines, config_file_exists, args.new_version, args.dry_run, | |||
config, config_file, config_newlines, config_file_exists, args.new_version, args.dry_run, args.no_update_config, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we bypass _update_config_file
altogether in case of no_update_config
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could do that too, would you prefer that? Was trying to avoid flow changes as much as possible.
Does this not bring the version in the config out of sync with the other version numbers? |
The goal was to better help with a tag-only workflow. So a config like:
With no current_version at all, and the version discovered only from the latest tag on the fly. |
OK. Do you think it's possible to have no |
This allows working completely off the latest tag support for current_version so the config file doesn't change on bump.