Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all art installation names are encoded as strings #1

Open
warpfactorfive opened this issue Oct 3, 2018 · 3 comments
Open

Ensure all art installation names are encoded as strings #1

warpfactorfive opened this issue Oct 3, 2018 · 3 comments

Comments

@warpfactorfive
Copy link

Describe the bug
Out of nearly 400 art installation entries, all but one were encoded in the JSON data as strings. One entry was encoded as a number.

To Reproduce
Get the API response: https://api.burningman.org/api/v1/art?year=2018
Search for 3.14
examine the entry's "name" field

Expected behavior
Should be a string, ie "name": "3.14",
Is actually encoded as a number: "name": 3.14,

@lostways
Copy link
Contributor

lostways commented Nov 7, 2018

Thanks for pointing this out. We are working on fixing this. It exposes a more general issue with the validation of types in the returning JSON.

@jeremedia
Copy link

I suggest ensuring all names are encoded as strings, not just art installations.

@ametabaron
Copy link

same for camps. 2 camps have a numeric name:

  • camp #a1X8X00000k2WqEUAU, name 3907
  • camp #a1X8X00000ko12mUAA, name 88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants