Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Docker image release #339

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Docker image release #339

wants to merge 3 commits into from
+157 −29

Conversation

DrJosh9000
Copy link
Contributor

Also run the release pipeline in a separate BK pipeline.

Fixes #51

@DrJosh9000 DrJosh9000 force-pushed the add-docker-image-release branch 4 times, most recently from 6ef777c to b9d4ea0 Compare December 2, 2024 23:58
yob
yob reviewed Dec 4, 2024
View reviewed changes
.buildkite/pipeline.release.yml Outdated Show resolved Hide resolved
yob
yob reviewed Dec 4, 2024
View reviewed changes
.buildkite/pipeline.release.yml Outdated Show resolved Hide resolved
yob
yob reviewed Dec 4, 2024
View reviewed changes
.buildkite/pipeline.release.yml Outdated Show resolved Hide resolved
@yob yob marked this pull request as ready for review December 4, 2024 05:59
yob
yob approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@yob yob left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I'm definitely a fan of splitting the release and build pipelines. I don't see a trigger step on the build pipeline, so I assume the release pipeline will trigger on a tag push to the GH repo?

DrJosh9000 and others added 2 commits December 4, 2024 17:09
@DrJosh9000
Add Docker image release
dd50744 
Also run the release pipeline in a separate BK pipeline
@DrJosh9000 @yob
Partially revert assume role changes
896b3e9 
Co-authored-by: James Healy <[email protected]>
@DrJosh9000
Copy link
Contributor Author

There should be a trigger step in .buildkite/pipeline.yml...

@DrJosh9000 @yob
Use new GH token path
26206f2 
Co-authored-by: James Healy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yob yob yob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Published docker image?
2 participants
@DrJosh9000 @yob