Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix $nav-desktop in Responsive Navigation Variables #260

Open
crystalms opened this issue Oct 26, 2022 · 0 comments
Open

Fix $nav-desktop in Responsive Navigation Variables #260

crystalms opened this issue Oct 26, 2022 · 0 comments

Comments

@crystalms
Copy link

crystalms commented Oct 26, 2022

https://github.com/bu-ist/responsive-foundation/blob/4.0.1/css-dev/burf-theme/layout/_navigation.scss#L740

When customizing the $nav-desktop variable in r-summer, I had to add some styles to override this. I think it should be $nav-desktop instead of $sm (the default setting of $nav-desktop), so if someone enters a different value, this will work as expected.

Also, I didn't see an option for $nav-desktop in the list of Responsive Navigation Variables within r-summer, so I didn't realize it was available until digging through BURF. We might want to add it if it's missing from newer versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant