Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button block needs better Link component #264

Open
acketon opened this issue Jul 7, 2020 · 1 comment · May be fixed by #284
Open

Button block needs better Link component #264

acketon opened this issue Jul 7, 2020 · 1 comment · May be fixed by #284
Labels
💡 Type: Enhancement

Comments

@acketon
Copy link
Member

acketon commented Jul 7, 2020

in the 5.4 fixes: #256 the previous custom "link" component was breaking in the new version of WordPress. I replaced it temporarily by copying the link component from the Leadin block which displays in the sidebar.

A better fix would be to use the Link component in the toolbar like the default button block. (not the link "formatting" button on the Rich text field though)
@ashleykolodziej
Copy link
Contributor

Use the URL popover component here per @acketon. It doesn't take up space in the editor.

@kyleevansio kyleevansio linked a pull request Aug 12, 2020 that will close this issue
Open
@kyleevansio kyleevansio linked a pull request Aug 12, 2020 that will close this issue
Wp upgrade/5.4 button block link fix #284
Open
@acketon acketon mentioned this issue Jun 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💡 Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wp upgrade/5.4 button block link fix bu-ist/bu-blocks
2 participants
@ashleykolodziej @acketon