Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cinemagraph video to photo essay block #135

Open
gcharlie opened this issue Jun 12, 2019 · 2 comments · May be fixed by #173
Open

Add cinemagraph video to photo essay block #135

gcharlie opened this issue Jun 12, 2019 · 2 comments · May be fixed by #173

Comments

@gcharlie
Copy link
Contributor

Right now the photo essay only supports upload image or image from media library. We need support for cinemagraph video from url

@acketon
Copy link
Member

acketon commented Jun 14, 2019

@philcable not sure how difficult of a change this is to swap in our other background image component so we can support cinemagraphs and/or buniverse videos. The idea is that a photo essay should allow a photo or video or cinemagraph as part of the storytelling.

If we do this, I'll have to also update the JS modal that has been added so it can handle a video in addition to a photo when clicking and "zooming" into the photo.

@philcable philcable linked a pull request Aug 7, 2019 that will close this issue
@acketon
Copy link
Member

acketon commented Jul 22, 2020

this work looks like it is mostly done... the PR needs to be updated and we will need proper block deprecation in order to update the block as this block is heavily used in the sites now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants