Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mentor-web doesn't allow underscores in state names #1

Open
ySteinhart1 opened this issue Apr 22, 2020 · 2 comments
Open

mentor-web doesn't allow underscores in state names #1

ySteinhart1 opened this issue Apr 22, 2020 · 2 comments
Labels
investigating Requires further inspection mentor parity Differences between Mentor and the mentor-web implemenation

Comments

@ySteinhart1
Copy link

Mentor allows states to be named with alphanumeric characters and underscores. Haven't had the chance to test it yet, but I think it can be fixed by changing line 63 of mentor.pegjs in mentor-parser from:
State "state" = $ [a-zA-Z0-9]+
to
State "state" = $ [a-zA-Z0-9_]+

@btk5h
Copy link
Owner

btk5h commented Apr 22, 2020

Rereading the documentation, it looks like Mentor should support underscores in state labels, but I haven't been able to get it to work locally. Mentor seems to give an invalid syntax error when I try it.

@ySteinhart1
Copy link
Author

Hmm, I thought it was working with underscores last time I tried it, but now I'm getting some errors too.

@btk5h btk5h added investigating Requires further inspection mentor parity Differences between Mentor and the mentor-web implemenation labels Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigating Requires further inspection mentor parity Differences between Mentor and the mentor-web implemenation
Projects
None yet
Development

No branches or pull requests

2 participants