-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix event codes corruption in PCF files #14
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
======================================
Coverage 0.37% 0.37%
======================================
Files 6 6
Lines 267 267
======================================
Hits 1 1
Misses 266 266
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I tested it and I see the same behaviour... :( Did you manage to obtain a good register of the events? Is there something I need to reproduce this? |
Strange... What script are you running to test? I'm upgrading |
I am using the same script that I used for testing before. But the code that registers the events is in the initialization function, so I think that the the actual code that we trace should not affect on this... |
I actually have been fighting Docker and Extrae_jll because it downloads an incompatible PAPI version for the currently built Extrae binary. yeah, i agree that the traced software should not affect. I’ve been testing that the value codes are correctly taken at the register function and it seems that is correct. Also, type codes are correctly generated. It looks like the only problem is how we pass the vector of value codes to the @CCall. I cannot test it right now until I fix some problems but I can only ask you: did you correctly check out to the branch of this PR? Did you reset the Julia terminal? Did you precompile the package? Keep in mind that in order to see any change of the code reflected, you have to restart the Julia REPL. |
Yes, I have everything set up correctly. I always run a new Julia process for every test with the script as a parameter (i run it with |
This would be great. Thanks. I will try also myself when I finish updating the |
Fixes #13. The problem was (again) the wrapping of some
Vector{Int}
into aRef
for a@ccall
.@clasqui could you try this code to check if it works? I will merge it when you give me the ok.