Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP CS Fixer levels should be in lowercase and php-cs-fixer errors are not detected #94

Open
xocasdashdash opened this issue Mar 30, 2017 · 2 comments

Comments

@xocasdashdash
Copy link

In the following lines: https://github.com/bruli/php-git-hooks/blob/master/src/PhpGitHooks/Module/PhpCsFixer/Service/PhpCsFixerTool.php#L45-L59

The php-cs-fixer levels are defined in uppercase, but php-cs-fixer fails if it uses that configuration if you run this locally:
'bin/php-cs-fixer' '--dry-run' 'fix' 'src/Cueball/PixelBundle/Controller/alpha/PixelController.php' '--level=SYMFONY'
The command fails, but the failure is not detected because on https://github.com/bruli/php-git-hooks/blob/master/src/PhpGitHooks/Module/PhpCsFixer/Infrastructure/Tool/PhpCsFixerToolProcessor.php#L79 you use the normal output and the php-cs-fixer process writes to the error output (if you change the method to use getErrorOutput you start seeing the errors)

@xocasdashdash xocasdashdash changed the title PHP CS Fixer levels should be in lowercase PHP CS Fixer levels should be in lowercase and php-cs-fixer errors are not detected Mar 30, 2017
@itaelle
Copy link

itaelle commented Aug 31, 2017

Will this ever be fixed? :)

@bruli
Copy link
Owner

bruli commented Sep 20, 2017

Sorry by the delay.
I will fix it coming soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants