Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change license on models #72

Merged
merged 7 commits into from
Jan 20, 2023
Merged

Change license on models #72

merged 7 commits into from
Jan 20, 2023

Conversation

Godnoken
Copy link
Contributor

As per #58 I'm taking action on this matter. Not a good look to have a license stating that the models produced by Bergamot project are under CC BY-SA and then some of the models have a CC BY-NC-SA license attached to them when downloaded.

@snukky Agreed to change here; #17 (comment)

Looking to confirm #17 that all the other models under the CC BY-NC-SA are agreed to be under CC BY-SA instead with:
@ZJaume
@sukantasen
and Maximiliana Behnke whom I can not find on Github.

I will contact each person per email and make changes to their models if agreed upon.

Hope this is ok.

@ZJaume
Copy link
Contributor

ZJaume commented Jan 16, 2023

LGTM! Mine were uploaded on the license of the repo (CC BY-SA). Then @XapaJIaMnu added deployment entries with NC, maybe it was a mistake? Anyway, yes please, removing NC would be nice.

@Godnoken
Copy link
Contributor Author

Then @XapaJIaMnu added deployment entries with NC, maybe it was a mistake?

That sounds likely as he agreed to the license himself in the other pull request.

Perfect, you can ignore my email then hehe. I will make the changes, thank you.

@Godnoken
Copy link
Contributor Author

It seems that @sukantasen email that is in the catalog-entry.yml files doesn't exist anymore; [email protected]

Let's hope he/she is active here or potentially if anyone else knows how to get in touch with them.

@Godnoken
Copy link
Contributor Author

@XapaJIaMnu I assume I should change the models in your name too? They're currently CC BY.


I just noticed #49

Do we want the catalog-entry.yml info incorporated into model-info.json, or kept separate?

@XapaJIaMnu
Copy link
Contributor

Yes, please do, if noone else minds, remove the NC entry.

@XapaJIaMnu
Copy link
Contributor

Is this waiting on anything else to be marked as ready?

@Godnoken
Copy link
Contributor Author

Yes, Maximiliana & @sukantasen have not responded.
I do not know whether they have agreed to this somewhere else earlier nor if they're even reachable at this point.

If they don't respond I assume we won't change the licenses on their curated models and just merge this?

@sukantasen
Copy link
Contributor

I don't mind, please change the license as needed.

@Godnoken
Copy link
Contributor Author

Brilliant. Does anyone how to contact Maximiliana?

@kpu
Copy link
Member

kpu commented Jan 20, 2023

@fiqas

@fiqas
Copy link

fiqas commented Jan 20, 2023

I apologise for a late response. Please change the license if needed.

@Godnoken Godnoken marked this pull request as ready for review January 20, 2023 13:58
@Godnoken
Copy link
Contributor Author

No worries, thank you for the response.

All good to merge now.

@XapaJIaMnu XapaJIaMnu merged commit c914c8f into browsermt:master Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants