Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ultima Single Sample outputs to VerifyNA12878 tests #1154

Open
meganshand opened this issue Dec 18, 2023 · 3 comments
Open

Add Ultima Single Sample outputs to VerifyNA12878 tests #1154

meganshand opened this issue Dec 18, 2023 · 3 comments

Comments

@meganshand
Copy link
Contributor

We expect small changes in the Ultima single sample pipelines when updating versions of software because there is a filtering method applied that uses a random seed (which fills in the TREE_SCORE annotation and provides the single sample filtered VCF). It would be helpful for future updates if we could include the NA12878 used for the Scientific Tests in the VerifyNA12878 tests to make the decision to update or not easier.

@jessicaway
Copy link
Member

@mshand would you still like to see this update?

@meganshand
Copy link
Contributor Author

I still think this feature should happen at some point. It's most valuable the next time we change the single sample pipeline such that we need to evaluate the scientific tests, so the urgency could be calibrated around when we expect another batch of changes (I don't know of any coming in the near future).

@jessicaway
Copy link
Member

Thank you! We'll keep this open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants