Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Successful zed client exit code when lake service panicked #5270

Open
philrz opened this issue Sep 10, 2024 · 0 comments
Open

Successful zed client exit code when lake service panicked #5270

philrz opened this issue Sep 10, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@philrz
Copy link
Contributor

philrz commented Sep 10, 2024

tl;dr

With some operators (e.g., join) it's possible for a query to fail due to a panic in the lake service, but the zed client just sees no query response and a successful exit code of 0. This is a problem since the tooling often uses this same query response pattern for success cases, e.g., a search that finds no matches.

Details

Repro is with GA Zed tagged v1.15.0. Repro steps are shown in #5097.

This was a secondary issue originally surfaced in #5097 (comment). Since the primary issue #5097 has been addressed, I'm opening this new issue to capture the remaining problem for future consideration.

In a group discussion @nwt mentioned that the problem of the successful exit code is a known problem that shows up in a couple operators (join and sort were the two mentioned, I think) where a goroutine is used and the plumbing is not present to gracefully handle a panic. He explained that it's not a hard thing to fix, but it's kind of messy, which is why it's not been taken up yet.

@philrz philrz added the bug Something isn't working label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant