Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pcapng files with embedded tls keys #264

Open
alberto-bc opened this issue Oct 6, 2020 · 2 comments
Open

Support for pcapng files with embedded tls keys #264

alberto-bc opened this issue Oct 6, 2020 · 2 comments

Comments

@alberto-bc
Copy link

alberto-bc commented Oct 6, 2020

Since WireShark 3.0 it is possible to embed TLS secrets in a pcapng file. Following the WireShark documentation I created a pcapng file with the tls keys embeded in it.

Using such file I'm able to inspect http traffic in WireShark, but when I load the same file in Brim, no such data (plain/unencrypted http data) is available.
Since Decryption Secrets Blocks are part of the pcapng specification, are there any plans to support these files in Brim?

@philrz
Copy link
Contributor

philrz commented Oct 7, 2020

@alberto-bc: Thanks for your interest in Brim!

There are currently no plans to support decryption in Brim. At the moment, the heavy lifting of creating summary logs out of packet captures is handled by an embedded Zeek. So based on the Brim architecture, that's normally where we'd look for such decryption to happen. A recent thread on the Zeek public Slack confirms that their core developers don't have this on their to-do list:

image

Just brainstorming, but having looked at the Internet Draft you linked to, maybe it would be technically feasible for Brim to run the packet capture through a preprocessing phase before passing it to Zeek, such that these secrets could be leveraged for decryption when present. The zq tools that are also embedded with Brim include a pcap tool that's used for indexing captures and other operations, and perhaps it could be extended to handle this.

The core Brim dev team is busy with other priorities at the moment, so even if something were technically feasible, it's unlikely to be something addressed in the near team. We'll hold this issue open to continue gathering interest and in case there's interest in the community (Zeek's or our own) in starting to dig into this area.

@philrz philrz transferred this issue from brimdata/zui Aug 15, 2022
@philrz
Copy link
Contributor

philrz commented Aug 15, 2022

In the time since this issue was first opened, pcap processing is now handled by a separate external tool Brimcap that's bundled with Brim. It seems like if we wanted to cover this, brimcap itself might need to be able to perform the decryption on the fly whenever reading a pcap stream for any reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants