Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade function ordering #62

Open
lisaslyis opened this issue Apr 8, 2016 · 1 comment
Open

Upgrade function ordering #62

lisaslyis opened this issue Apr 8, 2016 · 1 comment

Comments

@lisaslyis
Copy link

upgradeDB function stores the upgrade callback functions with its version number as a key in javascript associative arrays.

But the ordering of key is not guaranteed to be preserved in javascript. (I'm not sure if the ordering is preserved in all browsers although it is not in javascript specification) so there is a possibility to apply modification to db in wrong order.

eg. create object-storeA in version1 and delete object-storeA in version2. (these should not be applied in reverse order)

@lisaslyis lisaslyis reopened this Apr 8, 2016
@bramski
Copy link
Owner

bramski commented Oct 26, 2016

Can you repro? This should be easy to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants