Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<mods:physicalLocation> not crosswalking on deposit as expected #144

Closed
mrdsaunders opened this issue Nov 28, 2019 · 3 comments
Closed

<mods:physicalLocation> not crosswalking on deposit as expected #144

mrdsaunders opened this issue Nov 28, 2019 · 3 comments

Comments

@mrdsaunders
Copy link
Collaborator

The deposit crosswalk test screen for Pub ID 1012242 is outputting:

 <mods:location>
                <mods:physicalLocation>location test artefact</mods:physicalLocation>
</mods:location>

However it is not being ingested. The Sword output for that tag is empty:

<mods:location/>

What am I missing?

@tomwrobel tomwrobel self-assigned this Nov 28, 2019
@tomwrobel tomwrobel added this to the Complete crosswalk milestone Nov 28, 2019
@tomwrobel
Copy link
Collaborator

@mrdsaunders no idea, I'll take a look tomorrow

@bodleian bodleian deleted a comment from tomwrobel Nov 29, 2019
@bodleian bodleian deleted a comment from tomwrobel Nov 29, 2019
tomwrobel added a commit to tomwrobel/willow_sword that referenced this issue Nov 29, 2019
@tomwrobel
Copy link
Collaborator

tomwrobel commented Nov 29, 2019

Fixed in [feature/ora_customizations 3c46c23] Add physicalLocation to crosswalks

Depoloyed, @mrdsaunders please retest with a new deposit (the values weren't being ingested on deposit or sent on harvest)

please close when fixed

@tobypitts
Copy link
Collaborator

@mrdsaunders @tomwrobel I have retested with Pubs: 1012284/ uuid_0bd2aa29-c829-4cc2-a44f-20300e8fb4af type: artefact

Location value can be read in Review forms correctly. Modified value can be sent back to Oxris. I'm happy that this is now working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants