Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture Access Token for Github Auth #80

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jamescarr
Copy link

I'm using mongoose-auth for a github based mashup I'm working on and needed the access token to make API requests on behalf of the user. Unfortunately it seems that the accessToken doesn't get captured so I added it. :)

@wookiehangover
Copy link

wow, just ended up doing something similar, but attached the token to the user's session rather than into mongo. FWIW, given the nature of oauth tokens, it's probably not a great idea to persist them to your database. edit: having given it some more thought, it's probably fine either way.

anyway, +1 for exposing oauth response tokens.

@jamescarr btw, nice blog!

@jamescarr
Copy link
Author

@bnoguchi anyway we can get this closed? Let me know if there is anything I should do to clean this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants