Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config entry matcher.distance.min is not read as double which would be more flexible #101

Open
argltuc opened this issue Apr 5, 2018 · 2 comments · May be fixed by #102
Open

config entry matcher.distance.min is not read as double which would be more flexible #101

argltuc opened this issue Apr 5, 2018 · 2 comments · May be fixed by #102
Labels
bug

Comments

@argltuc
Copy link

argltuc commented Apr 5, 2018

Config entry matcher.distance.min is read by MatcherServer and TrackerServer as integer but is internaly used as double.
If it would read from config file as double, config would be more flexible and intuitive.

Are there any specific reasons, why matcher.distance.min is read as integer?
@smattheis
Copy link

I agree, it makes more sense as double.

@smattheis smattheis added the bug label Apr 5, 2018
@argltuc
Copy link
Author

argltuc commented Apr 5, 2018

I will provide a PR in some minutes

@argltuc argltuc linked a pull request Apr 5, 2018 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Problem: config entry matcher.distance.min is read as integer instead of double argltuc/barefoot
2 participants
@smattheis @argltuc