Firehose sends empty string in t of Error Frame (op is -1)

[MarshalX]

Describe the bug

Hello, it is me again 😢

t is not optional in error frame. According to the docs:

t ("type", string, optional): required if op is 1, indicating the Lexicon sub-type for this message, in short form. Does not include the full Lexicon identifier, just a fragment. Eg: #commit. Should not be included in header if op is -1. (atproto.com/specs/event-stream#streaming-wire-protocol-v0)

To Reproduce

1. Listen for firehose
2. Wait until error frame will be sent
3. Check the value of the frame
4. You will see empty string for t field

{'t': '', 'op': -1}

Expected behavior

When error happens t should not be provided at all

Additional context

MarshalX/atproto#430

It is expected? Should firehose listeners be ready to ignore t for op -1 on client side?

[bnewbold]

Hrm, I suspect a golang bug. Shoudl maybe have "omitempty" here:

https://github.com/bluesky-social/indigo/blob/main/events/events.go#L152

@brianolson @dholms @ericvolp12

[brianolson]

Yeah, I think omitempty will do what we want.

[jaredmantell]

if i fix this will you guys give me 100 thousan dollars a year and a job