Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Updated rxjs to 5.4.2 #921

Conversation

Blackbaud-TrevorBurch
Copy link
Member

@blackbaud-sky-savage
Copy link
Collaborator

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 471d396
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/256105164

(Please note that this is a fully automated comment.)

@Blackbaud-TrevorBurch
Copy link
Member Author

This appears to be possibly related to the fact that when this builds it is pulling in RXJS 5.4.2 for skyux but RXJS 5.4.0 for builder. I'm going to try to look into this more but that is what it looks to me like is the issue based on the build logs.

@Blackbaud-PatrickOFriel
Copy link
Contributor

Yeah we might have to point the version of builder to your branch in github until we get builder released with the rxjs changes

@Blackbaud-TrevorBurch
Copy link
Member Author

Ok. I'll push a commit that does that and then let you give it a look.

@Blackbaud-TrevorBurch
Copy link
Member Author

Will that cause issues with the fact that rc 7 is incompatible with rc 9 of builder and my builder branch is off of master which would be rc 9?

@Blackbaud-PatrickOFriel
Copy link
Contributor

Nope, SKYUX only uses builder to build documentation, it runs its unit tests differently so the font-face observer problem wont occur

@codecov-io
Copy link

codecov-io commented Jul 21, 2017

Codecov Report

Merging #921 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #921   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         301    301           
  Lines        5531   5531           
  Branches      698    698           
=====================================
  Hits         5531   5531

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac90387...e80c1af. Read the comment docs.

@blackbaud-sky-savage
Copy link
Collaborator

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 064a2f8
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/256149730

(Please note that this is a fully automated comment.)

@blackbaud-sky-savage
Copy link
Collaborator

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: e80c1af
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/256155312

(Please note that this is a fully automated comment.)

@Blackbaud-PatrickOFriel Blackbaud-PatrickOFriel merged commit 2fd689b into blackbaud:master Jul 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants