-
Notifications
You must be signed in to change notification settings - Fork 65
Updated rxjs to 5.4.2 #921
Updated rxjs to 5.4.2 #921
Conversation
Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: 471d396 (Please note that this is a fully automated comment.) |
This appears to be possibly related to the fact that when this builds it is pulling in RXJS 5.4.2 for skyux but RXJS 5.4.0 for builder. I'm going to try to look into this more but that is what it looks to me like is the issue based on the build logs. |
Yeah we might have to point the version of builder to your branch in github until we get builder released with the rxjs changes |
Ok. I'll push a commit that does that and then let you give it a look. |
Will that cause issues with the fact that rc 7 is incompatible with rc 9 of builder and my builder branch is off of master which would be rc 9? |
Nope, SKYUX only uses builder to build documentation, it runs its unit tests differently so the font-face observer problem wont occur |
Codecov Report
@@ Coverage Diff @@
## master #921 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 301 301
Lines 5531 5531
Branches 698 698
=====================================
Hits 5531 5531 Continue to review full report at Codecov.
|
Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 064a2f8 (Please note that this is a fully automated comment.) |
Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: e80c1af (Please note that this is a fully automated comment.) |
#885